make: rework kind-install-cilium-clustermesh for Cilium CLI Helm mode #26753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/clustermesh
qmonnet
reviewed
Jul 11, 2023
Cilium CLI v0.15 leverages the Helm-based installation mode by default, and it is the one which supports Cilium v1.14 and above. Let's adapt the kind-install-cilium-clustermesh Makefile target to work properly with it. While being there, let's also add the possibility to enable kvstoremesh if the dedicated variable is set. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/make-kind-install-cilium-clustermesh
branch
from
9f723dc
to
7a4ed37
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
aanm
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cilium CLI v0.15 leverages the Helm-based installation mode by default, and it is the one which supports Cilium v1.14 and above. Let's adapt the
kind-install-cilium-clustermeshMakefile target to work properly with it.While being there, let's also add the possibility to enable kvstoremesh if the dedicated variable is set.
Marking for backport to v1.14 because Cilium CLI v0.15 supports Cilium 1.14 and newer.