Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace cilium/customvet by cilium/linters #26755

Merged
merged 1 commit into from Jul 12, 2023

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Jul 11, 2023

The cilium/customvet repository is now archived and replaced by cilium/linters.

The cilium/customvet repository is now archived and replaced by
cilium/linters.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jul 11, 2023
@rolinh rolinh requested review from a team as code owners July 11, 2023 08:27
@rolinh rolinh requested a review from tklauser July 11, 2023 08:27
@nathanjsweet
Copy link
Member

go->precheck->customvet ran successfully. Ready-to-merge.

@nathanjsweet nathanjsweet added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.5 Jul 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.12 Jul 11, 2023
@julianwiedmann julianwiedmann merged commit 41c4174 into main Jul 12, 2023
56 checks passed
@julianwiedmann julianwiedmann deleted the pr/rolinh/customvet-linters branch July 12, 2023 08:18
@jibi jibi mentioned this pull request Jul 13, 2023
13 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 13, 2023
@aanm aanm added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 14, 2023
@gandro
Copy link
Member

gandro commented Jul 17, 2023

@rolinh I'm marking this as backport/author - pulling the new linters package bumps some other dependencies on the v1.13 branch, e.g.

        go.uber.org/goleak v1.2.0
        go.uber.org/multierr v1.8.0
        go.universe.tf/metallb v0.11.0
-       golang.org/x/crypto v0.3.0
+       golang.org/x/crypto v0.11.0
        golang.org/x/exp v0.0.0-20221106115401-f9659909a136
-       golang.org/x/net v0.10.0
-       golang.org/x/sync v0.1.0
-       golang.org/x/sys v0.8.0
-       golang.org/x/term v0.8.0
+       golang.org/x/net v0.12.0
+       golang.org/x/sync v0.3.0
+       golang.org/x/sys v0.10.0
+       golang.org/x/term v0.10.0
        golang.org/x/time v0.2.0
-       golang.org/x/tools v0.6.0
+       golang.org/x/tools v0.11.0

I'm not sure that's intended.

If you don't think this should be backported, then feel free to remove the labels.

@gandro gandro added the backport/author The backport will be carried out by the author of the PR. label Jul 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 17, 2023
@rolinh
Copy link
Member Author

rolinh commented Jul 17, 2023

pulling the new linters package bumps some other dependencies on the v1.13 branch
I'm not sure that's intended.

I think it's because deps were bumped in the linters repo. I'll handle the backport and point to the version just before the deps updates, to be on the safe side.

@gandro gandro mentioned this pull request Jul 17, 2023
6 tasks
@gandro gandro removed needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jul 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from main in 1.13.5 Jul 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from main in 1.12.12 Jul 17, 2023
@rolinh
Copy link
Member Author

rolinh commented Jul 17, 2023

Discussed offline with @gandro, although the original repository is archived, it only contains static analysis tools hence nothing critical from a runtime or security perspective. Therefore, let's not backport the change to the stable branches as it could cause more harm than not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.14.0
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

7 participants