Fix spelling for "WireGuard" #26764
Merged
Fix spelling for "WireGuard" #26764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/documentation
qmonnet
force-pushed
the
pr/fix-wg-spelling
branch
from
c02cd21
to
2c9c3c7
Compare
|
/test |
qmonnet
removed
the
dont-merge/blocked
squeed
approved these changes
Jul 12, 2023
gentoo-root
approved these changes
Jul 12, 2023
lambdanis
approved these changes
Jul 12, 2023
Let's fix the spelling ("WireGuard", and not with a different case)
where we can, in docs, comments or output strings that are not API.
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
"WireGuard" should be spelt "WireGuard", not "wireguard" or "Wireguard". We have a custom extension in the docs to ensure we never have the latter, for example. But it's been broken for a while, because we also added the lowercase "wireguard" entry to the list of spelling exceptions, making it case-insensitive in the eyes of the spell-checker. We need to remove this entry. Fixes: 19cd3f3 ("helm: Add `encryption.wireguard.userspaceFallback` value") Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/fix-wg-spelling
branch
from
2c9c3c7
to
f779215
Compare
|
I forgot to update the cmd-ref /test |
nathanjsweet
approved these changes
Jul 12, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late follow-up to #16293.
We had a custom filter for the spell checker in the docs, to ensure we'd never write "Wireguard" again. It's been broken since we added "wireguard" (considered case-insensitive) to the list of exceptions for the spell checker.
Let's fix this, and let's clean up the occurrences of "Wireguard" or "wireguard" where relevant in docs, comments, output strings that are not API.