ci: fix checking github.event.pull_request.head.sha
#26775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, checks like `if [ ${{ github.event.pull_request.head.sha }}
!= "" ]; then` are resulting in errors (`[: !=: unary operator
expected`) if the variable is empty.
This commit fixes this by wrapping it with a string.
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
mhofstetter
added
kind/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
julianwiedmann
added
release-note/ci
julianwiedmann
added
the
needs-backport/1.14
gandro
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, checks like
if [ ${{ github.event.pull_request.head.sha }} != "" ]; thenare resulting in errors ([: !=: unary operator expected) if the variable is empty. This is the case if the workflow is triggered via push on main (and not via pull_request).This commit fixes this by wrapping it with a string.