Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: test: pktgen cleanups #26776

Merged
merged 3 commits into from Jul 12, 2023
Merged

bpf: test: pktgen cleanups #26776

merged 3 commits into from Jul 12, 2023

Conversation

julianwiedmann
Copy link
Member

Remove most of the boilerplate code in the pktgen helpers.

@julianwiedmann
bpf: tests: pktgen: add wrapper for default ARP packet
f213780 
Follow the established pattern, where we have a separate helper that fills
in "default" values.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: tests: pktgen: have pktgen__push_rawhdr() validate the header
8f05472 
Move this responsibility from each caller into the helper itself.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: tests: pktgen: slim down packet builders
84bd0e5 
Reuse pktgen__push_rawhdr() to remove all the boiler plate code in the
protocol-specific helpers.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/ci This PR makes changes to the CI. labels Jul 12, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner July 12, 2023 08:04
aspsk
aspsk approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@julianwiedmann
Copy link
Member Author

BPF tests are green, ready for merge.

@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 12, 2023
@julianwiedmann julianwiedmann merged commit 6507703 into cilium:main Jul 12, 2023
56 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-test-improvements branch July 12, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @aspsk