ci: skip cosign / sbom in case of building images during cache rebuild #26786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker cache re-build is triggered via event `workflow_run`. In this case, the container image isn't puhed to a docker image, therefore `outputs.digest` isn't set. This results in cosign and sbom steps to fail because they depend on this. This commit fixes this by only executing these steps in case of a github event of type `push`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/bug
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker cache re-build is triggered via event
workflow_run. In this case, the container image isn't pushed to a docker registry, thereforeoutputs.digestisn't set. This results in cosign and sbom steps to fail because they depend on this.This commit fixes this by only executing these steps in case of a github event of type
push.Cosign & sbom support has been introduced after the cache. It looks like the cache-refresh use-case hasn't been considered.
Failing runs: https://github.com/cilium/cilium/actions/workflows/build-images-ci.yaml?query=event%3Aworkflow_run