contrib: add check for new files in check-(api|k8s)-code-gen scripts #26790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `check-(api|k8s)-code-gen` scripts verify that generated files are up to date, running a full regeneration and checking the resulting output of `git diff`. Yet, `git diff` does not include unstaged files, meaning that brand new files would be missed. Let's fix this running `git add --intent-to-add .` first to make them appear in the diff. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This commit adds the generated deepcopy for the tunnel map, which was missing as not detected by the check-k8s-code-gen script. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
release-note/misc
|
/test |
giorio94
changed the title
|
Conformance ginkgo hit #24514. Rerunning |
giorio94
changed the title
maintainer-s-little-helper
bot
added
the
ready-to-merge
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
check-(api|k8s)-code-genscripts verify that generated files are up to date, running a full regeneration and checking the resulting output ofgit diff. Yet,git diffdoes not include unstaged files, meaning that brand new files would be missed. Let's fix this runninggit add --intent-to-add .first to make them appear in the diff.