Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor (re)creation of data-loss tolerant bpf maps #26793

Open
nathanjsweet opened this issue Jul 12, 2023 · 1 comment
Open

Refactor (re)creation of data-loss tolerant bpf maps #26793

nathanjsweet opened this issue Jul 12, 2023 · 1 comment
Assignees
@ti-mo
Labels
kind/feature This introduces new functionality. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@nathanjsweet
Copy link
Member

From @ti-mo:

Maps that tolerate data loss (typically maps that are write-only from the agent side like ipcache and policy) should use Map.Recreate() instead of Map.OpenOrCreate()...

In addition to other benefits, Cilium can eliminate warning logs on bpf-map upgrades that change key or value sizes. Such warnings for data-loss tolerant bpf maps are not actionable and unnecessarily alarm cluster operators.

As part of this work or after it is completed #26656 should be reverted.
@nathanjsweet nathanjsweet added the kind/feature This introduces new functionality. label Jul 12, 2023
This was referenced Jul 12, 2023
Closed
Open
@nathanjsweet
Copy link
Member Author

The key-size warning issue will be solved by this one.

@aanm aanm added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Aug 4, 2023
@ti-mo ti-mo mentioned this issue Dec 20, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ti-mo ti-mo

Labels
kind/feature This introduces new functionality. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nathanjsweet @ti-mo @aanm