Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update clustermesh troubleshooting guide #26798

Merged
merged 1 commit into from Oct 16, 2023
Merged

docs: update clustermesh troubleshooting guide #26798

merged 1 commit into from Oct 16, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jul 13, 2023 •
edited

This PR updates some outdated pieces of information in the clustermesh troubleshooting guide, in particular about the TLS certificates.

Update the clustermesh troubleshooting guide

@giorio94 giorio94 added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Jul 13, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 13, 2023
@giorio94 giorio94 removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 13, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 13, 2023
@giorio94 giorio94 removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 25, 2023
@giorio94 giorio94 force-pushed the mio/clustermesh-troubleshooting branch from d6d0e6e to 1c7451d Compare October 10, 2023 07:47
@giorio94 giorio94 marked this pull request as ready for review October 10, 2023 07:50
@giorio94 giorio94 requested review from a team as code owners October 10, 2023 07:50
@giorio94
Copy link
Member Author

/test

learnitall
learnitall requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I have a couple of suggestions and then LGTM.

Documentation/operations/troubleshooting_clustermesh.rst Outdated Show resolved Hide resolved
Documentation/operations/troubleshooting_clustermesh.rst Outdated Show resolved Hide resolved
Documentation/operations/troubleshooting_clustermesh.rst Outdated Show resolved Hide resolved
Documentation/operations/troubleshooting_clustermesh.rst Outdated Show resolved Hide resolved
@giorio94
docs: update clustermesh troubleshooting guide
b40dd9f 
This commit updates some outdated pieces of information in the clustermesh
troubleshooting guide, in particular about the TLS certificates.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/clustermesh-troubleshooting branch from 1c7451d to b40dd9f Compare October 13, 2023 06:53
@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

Thank you for doing this. I have a couple of suggestions and then LGTM.

Suggestions applied, thanks!

@giorio94 giorio94 added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Oct 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.3 Oct 13, 2023
learnitall
learnitall approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 13, 2023
@squeed squeed merged commit 1761088 into cilium:main Oct 16, 2023
59 checks passed
@jrajahalme jrajahalme added this to Needs backport from main in 1.14.4 Oct 18, 2023
@jrajahalme jrajahalme removed this from Needs backport from main in 1.14.3 Oct 18, 2023
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 24, 2023
@tklauser tklauser mentioned this pull request Oct 24, 2023
Merged
14 tasks
@tklauser tklauser added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 25, 2023
@thorn3r thorn3r moved this from Needs backport from main to Backport done to v1.14 in 1.14.4 Nov 9, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@learnitall learnitall learnitall approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.4
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@giorio94 @learnitall @thorn3r @tklauser @squeed