bgpv1: Add GetRoutes method to Router interface and generic Path type #26803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
rastislavs
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rastislavs
force-pushed
the
bgp-get-routes
branch
2 times, most recently
from
87f7bf3
to
8736d6d
Compare
YutaroHayakawa
requested changes
Jul 13, 2023
Add a new generic Path type that which is an analogue of the GoBGP's Path object, but only contains a minimal fields required for Cilium's usecases. It consists of NLRI, Path Attributes and some status fields. We are relying on the GoBGP's pkg/packet/bgp package which is a generic BGP library (say net.IP package, but for BGP). We decided to reuse this library as a part of our router-independent intermediate representation because it's too painful for us to reinvent the BGP library by ourselves. This type will be used for implementing various BGP CPlane functionalities like retrieving the route. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com> Co-authored-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
bgp-get-routes
branch
from
8736d6d
to
98f63b3
Compare
Add a new GetRoutes method to the Router interface. This method retrieves routes from unerlying router's RIB. It supports retrieving Loc-RIB as well as Adj-RIB-In/Out. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com> Co-authored-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
bgp-get-routes
branch
from
98f63b3
to
7fb8fb5
Compare
|
@YutaroHayakawa I consolidated the commits |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GetRoutesmethod to the Router interface and genericPathandRoutetypes, that can be used to retrieve existing routes from the RIB of underlying router.This is the first step towards exposing the BGP routes via cilium API + CLI.