Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/ipsec: Extend troubleshooting for long key rotations #26809

Merged
merged 1 commit into from Jul 31, 2023
Merged

docs/ipsec: Extend troubleshooting for long key rotations #26809

merged 1 commit into from Jul 31, 2023

Conversation

pchaigno
Copy link
Member

This is documentation for the flag introduced in #24811 and the problem it addresses.

@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 13, 2023
@pchaigno pchaigno force-pushed the docs-ipsec-long-key-rotations branch 4 times, most recently from 5286567 to c9b7194 Compare July 20, 2023 14:41
@pchaigno pchaigno marked this pull request as ready for review July 20, 2023 14:42
@pchaigno pchaigno requested review from a team as code owners July 20, 2023 14:42
@aanm aanm added this to Needs backport from main in 1.14.1 Jul 26, 2023
@aanm aanm removed this from Needs backport from main in 1.14.0 Jul 26, 2023
zacharysarah
zacharysarah requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchaigno Some mild edits for the usual suspects

Documentation/security/network/encryption-ipsec.rst Outdated Show resolved Hide resolved
@pchaigno
docs/ipsec: Extend troubleshooting for long key rotations
2951c86 
This is documentation for the flag introduced in b7ecd90 ("ipsec,
option: Make the IPsec key rotation delay configurable") and the
problem it addresses.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the docs-ipsec-long-key-rotations branch from c9b7194 to 2951c86 Compare July 27, 2023 09:04
zacharysarah
zacharysarah approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchaigno Thanks for the updates!

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 28, 2023
@dylandreimerink dylandreimerink merged commit 9a01260 into cilium:main Jul 31, 2023
40 checks passed
@pchaigno pchaigno deleted the docs-ipsec-long-key-rotations branch July 31, 2023 08:16
@sayboras sayboras mentioned this pull request Jul 31, 2023
Closed
6 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 31, 2023
@sayboras sayboras mentioned this pull request Aug 1, 2023
Merged
6 tasks
@sayboras sayboras removed the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Aug 3, 2023
@sayboras sayboras added the backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. label Aug 3, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.14 in 1.14.1 Aug 10, 2023
@nebril nebril mentioned this pull request Aug 10, 2023
Merged
@giorio94 giorio94 mentioned this pull request Sep 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.1
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @gentoo-root @zacharysarah @dylandreimerink @sayboras