Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/testing/e2e: correct cilium-cli usage for helm mode #26840

Merged
merged 1 commit into from Jul 17, 2023
Merged

docs/testing/e2e: correct cilium-cli usage for helm mode #26840

merged 1 commit into from Jul 17, 2023

Conversation

tklauser
Copy link
Member

When using CILIUM_CLI_MODE=helm (which is the default as of cilium-cli v0.15.0), the --rollback option is no longer availble. Omit it from commands.

Also include the already existing cilium-cli download and installation instructions.

@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 14, 2023
@tklauser tklauser requested review from a team as code owners July 14, 2023 14:17
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 14, 2023
@tklauser
docs/testing/e2e: correct cilium-cli usage for helm mode
17ac9d5 
When using CILIUM_CLI_MODE=helm (which is the default as of cilium-cli
v0.15.0), the --rollback option is no longer available. Omit it from
commands.

Also include the already existing cilium-cli download and installation
instructions.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/testing-e2e-docs branch from 678d56e to 17ac9d5 Compare July 14, 2023 14:19
@joestringer joestringer merged commit 87cda2d into main Jul 17, 2023
40 checks passed
@joestringer joestringer deleted the pr/tklauser/testing-e2e-docs branch July 17, 2023 15:44
@gandro gandro mentioned this pull request Jul 18, 2023
Closed
9 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 18, 2023
@gandro gandro mentioned this pull request Jul 18, 2023
Merged
9 tasks
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 19, 2023
@aanm aanm moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@lambdanis lambdanis lambdanis approved these changes

@aditighag aditighag Awaiting requested review from aditighag aditighag is a code owner automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tklauser @joestringer @lambdanis @gandro