bpf: nat: small Masquerading improvements #26848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
sig/datapath
|
/test |
julianwiedmann
force-pushed
the
1.15-bpf-nat-masq-tuple
branch
from
402d8ed
to
34855d8
Compare
|
/test |
aspsk
requested changes
Jul 17, 2023
julianwiedmann
force-pushed
the
1.15-bpf-nat-masq-tuple
branch
from
34855d8
to
392e827
Compare
|
/test |
julianwiedmann
force-pushed
the
1.15-bpf-nat-masq-tuple
branch
from
392e827
to
7b6afab
Compare
|
/test |
julianwiedmann
force-pushed
the
1.15-bpf-nat-masq-tuple
branch
from
7b6afab
to
2e20db5
Compare
|
/test |
aspsk
reviewed
Jul 18, 2023
aspsk
approved these changes
Jul 18, 2023
Let the high-level SNAT routine provide its CT tuple to the masquerading helper, so that we can remove the duplicated extraction logic (and error handling). This requires us to consider the side-effects that ct_is_reply*() currently has on the tuple. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Clean up all the small parts that currently access the L3 header, and get the same information from the CT tuple instead. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
For now this just makes the error handling a bit more visible. But it should also enable us to consolidate the SNAT port extraction logic at a later point, so that ct_is_reply*() and snat_v*_nat() work with the same ports. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-bpf-nat-masq-tuple
branch
from
2e20db5
to
b043811
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More chipping away at the SNAT / Masquerading code. Trying to get to a point where we can pass a fully populated CT tuple to
snat_v*_nat(), and not repeat the same work there.