Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh/workflows: Optionally enable dual stack in ci-e2e #26856

Merged
merged 1 commit into from Jul 18, 2023
Merged

gh/workflows: Optionally enable dual stack in ci-e2e #26856

merged 1 commit into from Jul 18, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jul 17, 2023

Otherwise, when the IPv6 is disabled, the check-log-errors fails with:

Error while inserting service in LB map" error="Unable to upsert
service [fd00:10:96::8f2f]:8080 as IPv6 is disabled"
k8sNamespace=cilium-test k8sSvcName=echo-same-node

@brb
gh/workflows: Optionally enable dual stack in ci-e2e
3b57360 
Otherwise, when the IPv6 is disabled, the check-log-errors fails with:

    Error while inserting service in LB map" error="Unable to upsert
    service [fd00:10:96::8f2f]:8080 as IPv6 is disabled"
    k8sNamespace=cilium-test k8sSvcName=echo-same-node

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 17, 2023
@brb brb requested review from a team as code owners July 17, 2023 10:17
@brb brb requested a review from nbusseneau July 17, 2023 10:17
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.5 Jul 17, 2023
@brb brb mentioned this pull request Jul 17, 2023
Merged
@brb
Copy link
Member Author

brb commented Jul 17, 2023

/ci-e2e

sayboras
sayboras approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 17, 2023
@brb brb mentioned this pull request Jul 18, 2023
Merged
@aditighag aditighag merged commit b10d096 into main Jul 18, 2023
75 checks passed
@aditighag aditighag deleted the pr/brb/ci-e2e-opt-dual-stack branch July 18, 2023 16:10
@ysksuzuki ysksuzuki mentioned this pull request Jul 19, 2023
Merged
8 tasks
@gandro gandro mentioned this pull request Jul 19, 2023
Merged
6 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 19, 2023
@gandro gandro mentioned this pull request Jul 19, 2023
Merged
5 tasks
@gandro gandro added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.5 Jul 19, 2023
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 19, 2023
@gandro gandro added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.5 Jul 19, 2023
@gentoo-root gentoo-root mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbusseneau nbusseneau nbusseneau approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.5
Backport done to v1.13
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brb @nbusseneau @sayboras @gandro @aditighag