ci-gke: Set useDigest=false for Hubble Relay
#26890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with all other *-ci images, we should not use check the digest when pulling the image, as it is different for CI builds. On main this has not been an issue, because useDigest already defaults to false, but on release branches (such as v1.14), we do check the digest by default. This caused failing workflows on the v1.14 branch which should be fixed by this commit. Fixes: 98003d5 ("ci/github: Set `useDigest=false` for Hubble Relay") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/CI
|
/ci-gke |
michi-covalent
approved these changes
Jul 18, 2023
nbusseneau
approved these changes
Jul 18, 2023
|
the button is not green 😿 |
|
It can't be green, but it's still |
|
/test |
|
i made the button green |
michi-covalent
deleted the
pr/gandro/ci-hubble-relay-use-digest-false-in-gke
branch
maintainer-s-little-helper
bot
added
the
ready-to-merge
gandro
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.0
gandro
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with all other *-ci images, we should not use check the digest when pulling the image, as it is different for CI builds. On main this has not been an issue, because useDigest already defaults to false, but on release branches (such as v1.14), we do check the digest by default. This caused failing workflows on the v1.14 branch which should be fixed by this commit.
This extends the previous PR which was missing this change for the GKE workflow.
Fixes: 98003d5 ("ci/github: Set
useDigest=falsefor Hubble Relay")