Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed search for every page #26892

Merged
merged 1 commit into from Jul 19, 2023
Merged

docs: fixed search for every page #26892

merged 1 commit into from Jul 19, 2023

Conversation

geakstr
Copy link
Contributor

@geakstr geakstr commented Jul 18, 2023

Previously search input didn't work on some pages, updated docs theme should fix this.

Closes #26866

Theme fix PR: cilium/sphinx_rtd_theme#22

Previously search input didn't work on some pages,
updated docs theme should fix this.

Closes #26866

Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
@geakstr geakstr requested a review from aanm July 18, 2023 10:06
@geakstr geakstr self-assigned this Jul 18, 2023
@geakstr geakstr requested a review from a team as a code owner July 18, 2023 10:06
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 18, 2023
@aanm aanm added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.5 Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.12 Jul 18, 2023
@aanm aanm merged commit 2390916 into main Jul 19, 2023
41 checks passed
@aanm aanm deleted the pr/dima/fix-docs-search branch July 19, 2023 10:10
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.19 Jul 19, 2023
@qmonnet qmonnet added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.5 Jul 24, 2023
@qmonnet
Copy link
Member

qmonnet commented Jul 24, 2023

Regarding backports, this changes may fail on older branches where we don't run the same version of docutils to generate the docs (I don't remember for sure).

I'm updating Sphinx and add-ons to match the version we use on main, for separate reasons, on older branches; this PR could be backported at the same time (I've a PR open for 1.13 at the moment).

@nbusseneau nbusseneau added the backport/author The backport will be carried out by the author of the PR. label Jul 24, 2023
@nbusseneau
Copy link
Member

@qmonnet Thanks for the heads up, I indeed just hit a conflict so will be skipping this PR in my current batch and have marked the PR with backport/author, to let you handle it if that is OK.

@qmonnet
Copy link
Member

qmonnet commented Jul 24, 2023

Sounds good to me

@joestringer joestringer added the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 25, 2023
@aanm aanm added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 26, 2023
@qmonnet qmonnet added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.12 Jul 26, 2023
@qmonnet
Copy link
Member

qmonnet commented Jul 26, 2023

Backport to 1.12 was merged, 1.13 still in progress.

Heads up that I don't plan to backport the other changes (or this PR, either) to 1.11, given that we're dropping support very soon.

@gentoo-root gentoo-root added this to Needs backport from main in 1.11.20 Jul 26, 2023
@gentoo-root gentoo-root removed this from Needs backport from main in 1.11.19 Jul 26, 2023
@aanm aanm removed the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.13 in 1.13.5 Jul 26, 2023
@aanm aanm added the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.13 in 1.13.5 Jul 26, 2023
@aanm aanm added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Needs backport from main in 1.13.5 Jul 26, 2023
@gentoo-root gentoo-root added this to Needs backport from main in 1.13.6 Jul 26, 2023
@gentoo-root gentoo-root removed this from Needs backport from main in 1.13.5 Jul 26, 2023
@aanm aanm added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jul 26, 2023
@qmonnet qmonnet added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jul 27, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.13 in 1.13.6 Aug 10, 2023
@nebril nebril added this to Needs backport from main in 1.11.21 Aug 10, 2023
@nebril nebril removed this from Needs backport from main in 1.11.20 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport/author The backport will be carried out by the author of the PR. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.21
Needs backport from main
1.12.12
Backport done to v1.12
1.13.6
Backport done to v1.13
1.14.0
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

Search bar only works on homepage / landing page of docs.cilium.io
5 participants