Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix SCM_WEB reference on mtls-auth docs #26899

Merged
merged 1 commit into from Jul 18, 2023
Merged

docs: fix SCM_WEB reference on mtls-auth docs #26899

merged 1 commit into from Jul 18, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 18, 2023

No description provided.

@aanm
docs: fix SCM_WEB reference on mtls-auth docs
7175ec5 
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added requires-doc-change Requires updates to the documentation as part of the development effort. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 18, 2023
@aanm aanm requested review from a team as code owners July 18, 2023 15:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 18, 2023
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 18, 2023
@aanm
Copy link
Member Author

aanm commented Jul 18, 2023

/test

meyskens
meyskens approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michi-covalent
michi-covalent approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@aanm aanm merged commit 58ebdd2 into cilium:main Jul 18, 2023
51 checks passed
@gandro gandro mentioned this pull request Jul 19, 2023
Merged
6 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 19, 2023
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@zacharysarah zacharysarah Awaiting requested review from zacharysarah zacharysarah is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. requires-doc-change Requires updates to the documentation as part of the development effort.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @meyskens @michi-covalent @gandro