Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the server image from values for SPIRE #26911

Merged
merged 1 commit into from Jul 21, 2023
Merged

Use the server image from values for SPIRE #26911

merged 1 commit into from Jul 21, 2023

Conversation

meyskens
Copy link
Member

The SPIRE server wasn't yet set to the ones listed in the values. This fixes that oversight.

SPIRE Server image now is the value from the Helm values file

@meyskens meyskens added release-note/bug This PR fixes an issue in a previous release of Cilium. area/servicemesh GH issues or PRs regarding servicemesh release-blocker/1.14 This issue will prevent the release of the next version of Cilium. feature/authentication labels Jul 19, 2023
@meyskens meyskens requested review from a team as code owners July 19, 2023 07:19
@maintainer-s-little-helper
Copy link

Commit 97b1ed4bddbbe5ec1a8d367a82dcb76a320abf34 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 19, 2023
@maintainer-s-little-helper
Copy link

Commit 97b1ed4bddbbe5ec1a8d367a82dcb76a320abf34 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@meyskens
Copy link
Member Author

(sorry for the signoff issue, laptop broken using a spare one which was not setup fully yet)

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 19, 2023
mhofstetter
mhofstetter approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM

youngnick
youngnick approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice one. LGTM as well.

@aanm
Copy link
Member

aanm commented Jul 20, 2023

/test

@meyskens
Use the server image from values for SPIRE
b65a81b 
The SPIRE server wasn't yet set to the ones listed in the values.
This fixes that oversight.

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Copy link
Member Author

/test

sayboras
sayboras approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✔️

@sayboras sayboras added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 21, 2023
@aanm aanm merged commit 1a9778b into cilium:main Jul 21, 2023
65 checks passed
@nbusseneau nbusseneau mentioned this pull request Jul 24, 2023
Merged
21 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 24, 2023
@nbusseneau nbusseneau added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 25, 2023
@aanm aanm moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@aanm aanm aanm approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/authentication release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@meyskens @aanm @squeed @mhofstetter @sayboras @youngnick @nbusseneau