bgpv1: add CiliumBGPFamily CRD and utilize it #26940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ldelossa
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ldelossa
force-pushed
the
ldelossa/bgp-safi-afi
branch
from
2fd00c1
to
76f7f45
Compare
|
/test |
ldelossa
force-pushed
the
ldelossa/bgp-safi-afi
branch
from
76f7f45
to
e2b83f4
Compare
|
/test |
ldelossa
force-pushed
the
ldelossa/bgp-safi-afi
branch
2 times, most recently
from
ccd6ba6
to
948bd06
Compare
rastislavs
approved these changes
Jul 20, 2023
ldelossa
force-pushed
the
ldelossa/bgp-safi-afi
branch
2 times, most recently
from
29356bb
to
112290f
Compare
|
/test |
1 similar comment
|
/test |
maintainer-s-little-helper
bot
added
ready-to-merge
This commit introduces a new CiliumBGPFamily CRD which allows users to specify which Safi/Afi(s) they'd like to advertise or learn over a peer. If no CiliumBGPFamily(s) are provided in the CiliumBGPNeighbor CRD, a default set is provided which advertise/learn IPv4 and IPv6 prefixes. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
ldelossa/bgp-safi-afi
branch
from
112290f
to
e130ec4
Compare
|
/test |
|
Is this initial work towards MP-BGP? I wonder whether this or subsequent work in this direction may be appropriate for |
This does not really introduce any new functionality (yet), just makes the configuration a bit more more explicit for future extensions. That said, IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new CiliumBGPFamily CRD which allows users to specify which Safi/Afi(s) they'd like to advertise or learn over a peer.
If no CiliumBGPFamily(s) are provided in the CiliumBGPNeighbor CRD, a default set is provided which advertise/learn IPv4 and IPv6 prefixes.