Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.13] egressgw: consider egress interface when deleting stale IP rules #26947

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[v1.13] egressgw: consider egress interface when deleting stale IP rules #26947

merged 1 commit into from
Jul 21, 2023

Conversation

julianwiedmann
Copy link
Member

Manual backport of

Once this PR is merged, you can update the PR labels via:

for pr in 26846; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=26846

@julianwiedmann julianwiedmann added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Jul 20, 2023
@julianwiedmann
Copy link
Member Author

/test-backport-1.13

@julianwiedmann
egressgw: consider egress interface when deleting stale IP rules
f8b400a 
[ upstream commit 9e01ae0 ]

[ backporter's notes:
  - adjust for the different matchFunc in removeUnusedIpRulesAndRoutes()
  - adjust test, 1.13 doesn't have excludedCIDRs. Also assert the
    EgressRules.
]

When an EgressGW policy was updated to select a different egress interface,
delete all IP rules that still point to the old interface.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test-backport-1.13

@julianwiedmann
Copy link
Member Author

/test-1.26-net-next

@julianwiedmann
Copy link
Member Author

/test-1.16-4.19

@julianwiedmann julianwiedmann marked this pull request as ready for review July 20, 2023 14:01
@julianwiedmann julianwiedmann requested a review from a team as a code owner July 20, 2023 14:01
@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 21, 2023
@julianwiedmann
Copy link
Member Author

Over in tophat's queue for review / merge.

@aditighag aditighag merged commit 99994d1 into cilium:v1.13 Jul 21, 2023
61 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 21, 2023
@julianwiedmann julianwiedmann deleted the v1.13-egressgw-rules branch July 22, 2023 04:00
@gentoo-root gentoo-root mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @aditighag