Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: spell out that --egress-masquerade-interfaces is for iptables #26950

Merged
merged 1 commit into from Jul 24, 2023
Merged

config: spell out that --egress-masquerade-interfaces is for iptables #26950

merged 1 commit into from Jul 24, 2023

Conversation

julianwiedmann
Copy link
Member

Make it clear that this option applies to iptables-driven masquerading, not BPF-driven masquerading.

@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 20, 2023
@julianwiedmann
config: spell out that --egress-masquerade-interfaces is for iptables
1cdd374 
Make it clear that this option applies to iptables-driven masquerading,
not BPF-driven masquerading.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review July 20, 2023 13:04
@julianwiedmann julianwiedmann requested review from a team as code owners July 20, 2023 13:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 24, 2023
@julianwiedmann julianwiedmann merged commit 33c2726 into cilium:main Jul 24, 2023
65 checks passed
@julianwiedmann julianwiedmann deleted the 1.14-docs-egress-masq-iface branch July 24, 2023 17:36
@nbusseneau nbusseneau mentioned this pull request Jul 25, 2023
Merged
4 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 25, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julianwiedmann @squeed @tommyp1ckles @joestringer @nbusseneau