Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: add missing drop notifications #26956

Merged
merged 3 commits into from Jul 21, 2023
Merged

bpf: add missing drop notifications #26956

merged 3 commits into from Jul 21, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jul 20, 2023 •
edited

Fix up a few more missing drop notifications.

Add drop notifications from various error paths in the BPF datapath.

@julianwiedmann
bpf: host: add drop notification for missed tail call in to-lxc polic…
e9e4a2d 
…y path

Straight-forward fix for a missing drop notification.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 20, 2023
@julianwiedmann
bpf: lxc: add drop notifications for missed tail calls in to-container
c94ce3a 
cil_to_container() has some paths that don't raise a drop notification for
DROP_MISSED_TAIL_CALL. Fix them.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: lxc: add drop notification for high-scale ipcache path in to-con…
616225d 
…tainer

Don't just return DROP_INVALID, but also throw a drop notification.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title 1.15 bpf drop notify bpf: add missing drop notifications Jul 21, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review July 21, 2023 08:04
@julianwiedmann julianwiedmann requested a review from a team as a code owner July 21, 2023 08:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 21, 2023
@julianwiedmann julianwiedmann merged commit 614c174 into cilium:main Jul 21, 2023
65 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-drop-notify branch July 21, 2023 09:44
@nbusseneau nbusseneau mentioned this pull request Jul 24, 2023
Merged
21 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 24, 2023
@nbusseneau nbusseneau added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 25, 2023
@aanm aanm moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 26, 2023
@julianwiedmann julianwiedmann added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Oct 3, 2023
@julianwiedmann
Copy link
Member Author

note: for the 1.12 / 1.13 backports, the last patch in the series isn't required - hs-ipcache was only introduced in 1.14.

@sayboras sayboras mentioned this pull request Oct 6, 2023
Merged
5 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Oct 6, 2023
@sayboras sayboras mentioned this pull request Oct 6, 2023
Merged
5 tasks
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Oct 6, 2023
This was referenced Oct 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julianwiedmann @aspsk @nbusseneau @sayboras