egressgw: use Resource[T] to consume CiliumEgressGatewayPolicy #26960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
release-note/misc
lmb
changed the title
|
/test |
lmb
force-pushed
the
egw-cegp-resource
branch
2 times, most recently
from
7bf967e
to
38b1d6e
Compare
|
/test-runtime |
|
/privileged |
|
/test |
lmb
force-pushed
the
egw-cegp-resource
branch
2 times, most recently
from
3512bd7
to
1c7b154
Compare
lmb
commented
Jul 24, 2023
|
/test |
lmb
force-pushed
the
egw-cegp-resource
branch
2 times, most recently
from
da30942
to
8095e86
Compare
|
/test |
|
/ci-e2e |
|
/ci-e2e |
|
/ci-e2e |
|
/ci-e2e |
|
/ci-e2e |
|
/test |
markpash
reviewed
Aug 1, 2023
| } | ||
| } | ||
|
|
||
| func (manager *Manager) handlePolicyEvent(event resource.Event[*Policy]) { |
There was a problem hiding this comment.
Nit: this looks like it could just be merged into the above function.
There was a problem hiding this comment.
I split it out since processEvents is going to get more complicated as we migrate away from the monolithic k8s watchers. AFAIK we'll add at least Endpoint and Node. So I'd prefer to keep them split.
Don't rely on hive to construct a Manager, it's more trouble than it's worth. Instead create the necessary dependencies manually. This gives us much more control over which types are used for certain interfaces without having to fiddle with hive rules. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
The testsuite leaves around dummy interfaces if the test aborts for some reason. Use tb.Cleanup to avoid this behaviour. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Replace the copy pasta'd k8s watcher for CiliumEgressGatewayPolicy with resource.Resource. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
jibi
reviewed
Aug 1, 2023
jibi
approved these changes
Aug 1, 2023
youngnick
approved these changes
Aug 2, 2023
|
/test |
jibi
added
the
needs-backport/1.14
jibi
removed
the
needs-backport/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egressgw: manually construct Manager in tests
egressgw: use tb.Cleanup to tear down dummy interfaces
egressgw: use Resource[T] to consume CiliumEgressGatewayPolicy