Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Multi-Pool IPAM Docs for v1.14 Release #26967

Merged
merged 1 commit into from Jul 24, 2023
Merged

Updates Multi-Pool IPAM Docs for v1.14 Release #26967

merged 1 commit into from Jul 24, 2023

Conversation

danehans
Copy link
Contributor

Fixes: #26932

@danehans danehans requested review from a team as code owners July 20, 2023 19:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 20, 2023
@joestringer joestringer added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 24, 2023
joestringer
joestringer requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Minor nit on the multipool and a question later in the guide.

Documentation/network/concepts/ipam/multi-pool.rst Outdated Show resolved Hide resolved
Documentation/network/kubernetes/ipam-multi-pool.rst Show resolved Hide resolved
@danehans
Updates Multi-Pool IPAM Docs for v1.14 Release
9548223 
- Updates the nginx image that includes curl.
- Adds a step to test connectivity by curl'ing between pods.
- Adds a reference to cilium#26966

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
tommyp1ckles
tommyp1ckles approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks!

@joestringer joestringer merged commit f9198a0 into cilium:main Jul 24, 2023
40 checks passed
@nbusseneau nbusseneau mentioned this pull request Jul 25, 2023
Merged
4 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 25, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 25, 2023
@danehans danehans deleted the issue_26932 branch September 12, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@zacharysarah zacharysarah Awaiting requested review from zacharysarah zacharysarah is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test IPAM Multi-pool getting started guide with 1.14.0-rc.1
4 participants
@danehans @joestringer @tommyp1ckles @nbusseneau