Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutual-auth: Add beta label for helm and cli flags #26984

Merged
merged 1 commit into from Jul 24, 2023
Merged

mutual-auth: Add beta label for helm and cli flags #26984

merged 1 commit into from Jul 24, 2023

Conversation

sayboras
Copy link
Member

Only enabled flags are marked as beta, as other flags will not be taken into consideration if these enabled flags are not set as true.

Suggested-by: Paul Chaignon paul.chaignon@gmail.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2023
@sayboras sayboras added release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh labels Jul 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 21, 2023
@sayboras sayboras added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 21, 2023
@sayboras sayboras added the release-blocker/1.14 This issue will prevent the release of the next version of Cilium. label Jul 21, 2023
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review July 21, 2023 12:39
@sayboras sayboras requested review from a team as code owners July 21, 2023 12:39
@sayboras
mutual-auth: Add beta label for helm and cli flags
4b7ebc3 
Only enabled flags are marked as beta, as other flags will not be taken
into consideration if these enabled flags are not set as true.

Suggested-by: Paul Chaignon <paul.chaignon@gmail.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

/test

meyskens
meyskens approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joestringer joestringer merged commit 0254e20 into cilium:main Jul 24, 2023
64 of 65 checks passed
@nbusseneau nbusseneau mentioned this pull request Jul 24, 2023
Merged
21 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 24, 2023
@nbusseneau nbusseneau added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 25, 2023
@aanm aanm moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@meyskens meyskens meyskens approved these changes

@aanm aanm aanm approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/operator

@squeed squeed Awaiting requested review from squeed squeed is a code owner automatically assigned from cilium/helm

@zacharysarah zacharysarah Awaiting requested review from zacharysarah zacharysarah is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sayboras @joestringer @meyskens @aanm @nbusseneau