[v1.14] Revert "Add support for --hubble-redact=http-url-query" #26997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
added
kind/cleanup
maintainer-s-little-helper
bot
added
backport/1.14
ChrsMark
approved these changes
Jul 21, 2023
| @@ -1357,7 +1357,7 @@ | |||
| - bool | |||
| - ``false`` | |||
| * - :spelling:ignore:`hubble.metrics.enabled` | |||
| - Configures the list of metrics to collect. If empty or null, metrics are disabled. Example: enabled: - dns:query;ignoreAAAA - drop - tcp - flow - icmp - http You can specify the list of metrics from the helm CLI: --set hubble.metrics.enabled="{dns:query;ignoreAAAA,drop,tcp,flow,icmp,http}" | |||
| - Configures the list of metrics to collect. If empty or null, metrics are disabled. Example: enabled: - dns:query;ignoreAAAA - drop - tcp - flow - icmp - http You can specify the list of metrics from the helm CLI: --set metrics.enabled="{dns:query;ignoreAAAA,drop,tcp,flow,icmp,http}" | |||
There was a problem hiding this comment.
That was kind of irrelevant "fixup" but anyways we can fix it in a different standalone PR.
|
/test |
youngnick
approved these changes
Jul 24, 2023
|
/test-backport-1.14 |
gandro
approved these changes
Jul 24, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #23887 (comment) for motivation. We've determined we should create a a more flexible configuration scheme for redaction of http headers, so instead of shipping the current solution which isn't very flexible, revert it, and we'll ship in the next release with the more flexible configuration scheme.
This PR reverts 2/3 of the commits in #25746. I left the 1 commit which fixed an issue where a URL object was being mutated in some existing redaction code.