Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small documentation fixups #26999

Merged
merged 3 commits into from Jul 24, 2023
Merged

Small documentation fixups #26999

merged 3 commits into from Jul 24, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 21, 2023

No description provided.

@aanm aanm added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 21, 2023
@aanm aanm requested review from a team as code owners July 21, 2023 19:12
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 21, 2023
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jul 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2023
zacharysarah
zacharysarah previously requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aanm Nice. ✨ This review includes changes to text you haven't touched, but it's a chance to make small but meaningful improvements in a related PR.

Documentation/network/servicemesh/mutual-authentication/installation.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/mutual-authentication/installation.rst Outdated Show resolved Hide resolved
meyskens
meyskens approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For technical part of sig-servicemesh LGTM

@aanm aanm requested a review from zacharysarah July 24, 2023 12:09
@aanm aanm dismissed zacharysarah’s stale review July 24, 2023 12:09

Comments addressed

aanm added 3 commits July 24, 2023 14:10
@aanm
docs: remove 'reuse-values' from helm install
4064683 
The 'reuse-values' flag does not exist in helm install only on the
'upgrade' sub-command.

Fixes: 0a9b289 ("docs: add mutual-tls authentication")
Signed-off-by: André Martins <andre@cilium.io>
@aanm
docs: switch the tab ordering for mutual-auth docs
4d53dda 
We should give preference to Cilium-cli for installation of getting
started guides.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
docs: small improvements in mutual-authentication documentation
1025712 
Suggested-by: Sarah Corleissen <sarah.corleissen@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Jul 24, 2023

/test

@aanm aanm merged commit 5201b3c into cilium:main Jul 24, 2023
50 checks passed
@nbusseneau nbusseneau mentioned this pull request Jul 24, 2023
Merged
21 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 24, 2023
@aanm aanm moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @meyskens @zacharysarah @nbusseneau