Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp,docs: clarify MetalLB deprecation vs BGP-CP beta #27005

Merged
merged 1 commit into from Jul 24, 2023

Conversation

ldelossa
Copy link
Contributor

As a suggested follow up, further clarify that the MetalLB based BGP
control plane is being deprecated.

Signed-off-by: Louis DeLosSantos louis.delos@isovalent.com

Further clarify the deprecation of MetalLB BGP ControlPlane in user facing docs. 

@ldelossa ldelossa requested review from a team as code owners July 22, 2023 12:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 22, 2023
@ldelossa
Copy link
Contributor Author

Follow up here in reference to: #26951 (comment)

@ldelossa ldelossa added the release-note/misc This PR makes changes that have no direct user impact. label Jul 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 22, 2023
As a suggested follow up, further clarify that the MetalLB based BGP
control plane is being deprecated.

Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joestringer joestringer added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 24, 2023
@joestringer joestringer merged commit 6d6d1eb into cilium:main Jul 24, 2023
40 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 24, 2023
@nbusseneau nbusseneau mentioned this pull request Jul 25, 2023
4 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.0 Jul 25, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.0 Jul 25, 2023
@ldelossa ldelossa deleted the bgp-docs-update-pt2 branch July 26, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.0
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

4 participants