cilium: use absolute path to include Makefile.defs #27054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
release-note/minor
|
/test |
|
/test |
cilium/Makefile currently can't be included from elsewhere, since it uses a relative path to Makefile.defs. Copy the approach used for daemon and operator. At the same time, avoid a possible shell splitting issue by quoting the arguments to dirname. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
cilium-makefile-include
branch
from
9566bf7
to
91e68d0
Compare
|
/test |
joamaki
approved these changes
Jul 31, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium/Makefile currently can't be included from elsewhere, since it uses a relative path to Makefile.defs. Copy the approach used for daemon and operator.
At the same time, avoid a possible shell splitting issue by quoting the arguments to dirname.