v1.14 Backports 2023-07-25 #27055
Merged
v1.14 Backports 2023-07-25 #27055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 6d6d1eb ] As a suggested follow up, further clarify that the MetalLB based BGP control plane is being deprecated. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 33c2726 ] Make it clear that this option applies to iptables-driven masquerading, not BPF-driven masquerading. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 4863f81 ] In the example policy for l2-announcements, the example was using a label selector that said: `role: worker`. While it is possible to add such a label, most people will not do that and want to rely on the existing `node-role.kubernetes.io/<role>` labels added by kubeadm and similar tools. If an inexperienced user copies and pastes our example without modifying the node label selector, it will likely not work. This commit updates the example to be more realistic. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added
kind/backports
nbusseneau
requested review from
ldelossa,
julianwiedmann,
danehans and
dylandreimerink
julianwiedmann
approved these changes
Jul 25, 2023
|
This quick backport round was fast-tracked in preparation for the 1.14 release, it only makes changes to the documentation and helper strings, so we do not need to run any additional CI for this one. |
dylandreimerink
approved these changes
Jul 25, 2023
|
Documentation CI and Helm checks CI passed. This has got to be the fastest backport round in the history of backport rounds, maybe ever. Marking as |
nbusseneau
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via:
or with