Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use kubeProxyReplacement=true for Gateway API docs #27066

Merged
merged 1 commit into from Jul 26, 2023
Merged

docs: Use kubeProxyReplacement=true for Gateway API docs #27066

merged 1 commit into from Jul 26, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jul 25, 2023 •
edited

  • Use kubeProxyReplacement=true as partial and strict settings have been deprecated in v1.14.
  • Specify the same Helm values for Helm and Cilium-CLI instructions.
  • Move the Cilium CLI installation instructions out of the tabs. It's required for both Helm and Cilium-CLI instructions.

Fixes: #27060

deploy preview: https://deploy-preview-27066--docs-cilium-io.netlify.app/network/servicemesh/gateway-api/gateway-api.html

@michi-covalent michi-covalent added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 25, 2023
@michi-covalent
Copy link
Contributor Author

/test

sayboras
sayboras approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 25, 2023
@michi-covalent michi-covalent marked this pull request as ready for review July 25, 2023 21:33
@michi-covalent michi-covalent requested review from a team as code owners July 25, 2023 21:33
qmonnet
qmonnet requested changes Jul 25, 2023
View reviewed changes
Documentation/conf.py Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jul 25, 2023
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jul 25, 2023
@michi-covalent
docs: Use kubeProxyReplacement=true for Gateway API docs
e720a34 
- Use `kubeProxyReplacement=true` as `partial` and `strict` settings
  have been deprecated in v1.14.
- Specify the same Helm values for Helm and Cilium-CLI instructions.
- Move the Cilium CLI installation instructions out of the tabs. It's
  required for both Helm and Cilium-CLI instructions.

Fixes: #27060

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

/test

@aanm aanm added this to Needs backport from main in 1.14.1 Jul 26, 2023
@aanm aanm removed this from Needs backport from main in 1.14.0 Jul 26, 2023
qmonnet
qmonnet approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 26, 2023
@qmonnet qmonnet merged commit 4772468 into main Jul 26, 2023
54 checks passed
@qmonnet qmonnet deleted the pr/michi/gateway branch July 26, 2023 08:51
@nbusseneau nbusseneau mentioned this pull request Jul 26, 2023
Merged
6 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 26, 2023
@joestringer joestringer removed the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Jul 26, 2023
@joestringer joestringer added the backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. label Jul 26, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.14 in 1.14.1 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.1
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partial and strict are deprecated for helm installation
6 participants
@michi-covalent @sayboras @youngnick @qmonnet @joestringer @nbusseneau