ci-gke: adjust junit file names to matrix properties #27072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/bug/CI
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/gke-junit-filename
branch
from
34a1149
to
d046a6b
Compare
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/gke-junit-filename
branch
from
d046a6b
to
a4c7f59
Compare
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/gke-junit-filename
branch
from
a4c7f59
to
cbac8a7
Compare
|
/test |
Currently, the name of the junit files no longer matches the name of the
job including the values of the matrix properties.
This commit fixes this and uses `(${{ join(matrix.*, ', ') }})` to keep
the names in sync.
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/gke-junit-filename
branch
from
cbac8a7
to
7b72477
Compare
|
/test |
christarazi
approved these changes
Jul 26, 2023
aanm
approved these changes
Jul 27, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the name of the junit files no longer matches the name of the job including the values of the matrix properties.
This is kind of a requirement for external tooling to match them against a specific job.
This commit fixes this and uses
(${{ join(matrix.*, ', ') }})to keep the names in sync.