v1.13 Backports 2023-07-26 #27095
Merged
v1.13 Backports 2023-07-26 #27095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
kind/backports
nbusseneau
force-pushed
the
pr/v1.13-backport-2023-07-26
branch
from
8d6ac82
to
f855856
Compare
viktor-kurchenko
approved these changes
Jul 26, 2023
|
/test-backport-1.13 |
|
Note for maintainers: After merge, the following checks will need to be unmarked as required on
(note: ingress-conformance-test should also have been in this list, but it seems we had missed to mark it previously) And the following checks will need to be marked as required instead:
|
qmonnet
approved these changes
Jul 26, 2023
michi-covalent
approved these changes
Jul 26, 2023
joestringer
added
the
dont-merge/wait-until-release
|
@cilium/tophat, feel free to approve but I'll take care of merge after releases since I can then adjust the branch protection immediately afterwards. |
youngnick
approved these changes
Jul 28, 2023
[ upstream commit 944dddf ] To generate the gRPC API reference, we copy the "api" repository at the root of the repository to "Documentation/_api". This step is required everywhere we need to build the docs: - Locally, we run it through the "copy-api" target in Documentation/Makefile, before generating the HTML. - Same thing for the Netlify preview, where "copy-api" is a dependency for the "html-netlify" target. - However, on ReadTheDocs, where we generate and host the online documentation, we do not perform this step; nor do we use the Makefile at all. As a workaround, let's simplify the way we access the API reference. Instead of copying the docs, just symlink them from the Documentation directory. Signed-off-by: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
force-pushed
the
pr/v1.13-backport-2023-07-26
branch
from
f855856
to
6a8c102
Compare
|
Rebased following conflict with ce3a511 which was merged before this PR. No need to re-trigger any CI. |
nbusseneau
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via:
or with