Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldelossa/register bgpserver fix #27117

Merged
merged 1 commit into from Jul 27, 2023
Merged

ldelossa/register bgpserver fix #27117

merged 1 commit into from Jul 27, 2023

Conversation

ldelossa
Copy link
Contributor

@ldelossa ldelossa commented Jul 27, 2023 •
edited

Fixes an issue where an empty ControlPlaneState was used during registration of BGP speakers.

Fixes an issue where an empty ControlPlaneState was used during registration of BGP speakers. This would cause reconciliation issues as the current state would be unknown.

@ldelossa
bgpv1: do not supply empty control plane state
75eb01c 
This fixes an issue where an empty ControlPlaneState structure is
provided to NewServerWithConfig within the RouterManager.registerBGPServer
method.

Instead, continue passing the ControlPlaneState supplied by the caller
of registerBGPServer.

Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
@ldelossa ldelossa requested a review from a team as a code owner July 27, 2023 17:04
@ldelossa ldelossa requested a review from rastislavs July 27, 2023 17:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 27, 2023
@ldelossa ldelossa added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 27, 2023
rastislavs
rastislavs approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldelossa
Copy link
Contributor Author

/test

@joestringer
Copy link
Member

Is there a user-facing impact of this? I found it a bit difficult to really understand from the release note. If yes, could you clarify the release note further? If no, then release-note/misc or release-note/bug may be more appropriate (obviously with backport labels if relevant, based on backporting policy if this is a bugfix).

@ldelossa ldelossa added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Jul 27, 2023
@ldelossa
Copy link
Contributor Author

@joestringer okay updated. No backporting, since the bug was introduced before after the last release.

@joestringer joestringer removed the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 27, 2023
@ldelossa ldelossa merged commit 8ecef5c into main Jul 27, 2023
190 of 192 checks passed
@ldelossa ldelossa deleted the ldelossa/register-bgpserver-fix branch July 27, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldelossa @joestringer @rastislavs