Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to the quick install documentation for increasing inotify limits #27140

Merged
merged 1 commit into from Aug 4, 2023

Conversation

leblowl
Copy link
Contributor

@leblowl leblowl commented Jul 29, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Many systems have low inotify resource limits which can cause errors
when deploying enough pods. This issue has been encountered while
running the Cilium connectivity test (see: #22585). This commit adds a
note after the connectivity test instructions to help people increase
inotify limits if they experience this issue.

This commit at least partially fixes #22585, there may be more
work (e.g. CI).

Tested by building the docs locally.

@leblowl leblowl requested a review from a team as a code owner July 29, 2023 17:48
@leblowl leblowl requested a review from learnitall July 29, 2023 17:48
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 29, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 29, 2023
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leblowl Minor punctuation nit, otherwise LGTM for docs

Documentation/installation/cli-connectivity-test.rst Outdated Show resolved Hide resolved
@learnitall learnitall removed their request for review August 2, 2023 15:05
Many systems have low inotify resource limits which can cause errors
when deploying enough pods. This issue has been encountered while
running the Cilium connectivity test (see: cilium#22585). This commit adds a
note after the connectivity test instructions to help people increase
inotify limits if they experience this issue.

This commit at least partially fixes cilium#22585, there may be more
work (e.g. CI).

Signed-off-by: Lucas Leblow <lucasleblow@mailbox.org>
@leblowl leblowl force-pushed the pr/docs-quick-install-inotify branch from c3ab3c9 to 2284b29 Compare August 2, 2023 18:49
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Aug 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 4, 2023
@dylandreimerink dylandreimerink added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 4, 2023
@dylandreimerink dylandreimerink merged commit fc9c8a9 into cilium:main Aug 4, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium connectivity test failing in documented quick start procedure using kind running on Fedora
3 participants