fix: use proper helm param name for specifying pod cidr #27141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 874533f93b42b071f619bd34446b110dff3fd1b2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
yandzee
force-pushed
the
pr/renat/k3s-docs-typo-fix
branch
from
874533f
to
582b91a
Compare
|
Commit 874533f93b42b071f619bd34446b110dff3fd1b2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: Renat Tuktarov <yandzeek@gmail.com>
yandzee
force-pushed
the
pr/renat/k3s-docs-typo-fix
branch
from
582b91a
to
8c0c325
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
learnitall
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Nice catch! Thank you! One small nit that I have for you is the commit message, which could be a bit more specific. Something like:
docs: remove `clusterPoolIPv4PodCIDR option in k3s install
The option `clusterPoolIPv4PodCIDR option was deprecated in
Cilium 1.11 and removed from helm values in commit 1eef5ac.
This commit replaces an outdated reference to this option in
the k3s installation docs with the preferred option
`clusterPoolIPv4PodCIDRList`
qmonnet
added
area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Introduced in d3f2bcb ("Doc: Update k3s cilium installation to match k3s default podCIDR") which is in 1.14, I'm marking for backports for that release. |
qmonnet
added
the
needs-backport/1.14
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.1
sayboras
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.