helm: use local etcd client certificate when kvstoremesh is enabled #27177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When kvstoremesh is enabled, local agents connect to the local clustermesh-apiserver instance, rather than the remote one. Yet, when the TLS key/certificate pair of a remote cluster is manually specified, the helm chart currently configures it both to connect to the remote clustermesh-apiserver instance (which is correct) and to the local one (which prevents the connection from being established correctly as it is signed with a different CA). Let's fix this making sure that we always use the local TLS key/certificate pair when connecting to the local clustermesh-apiserver instance. Fixes: bd53860 ("kvstoremesh: add helm configuration") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug
giorio94
requested review from
a team and
YutaroHayakawa
and removed request for
a team
|
/test |
This was referenced Aug 1, 2023
YutaroHayakawa
approved these changes
Aug 1, 2023
brlbil
approved these changes
Aug 1, 2023
youngnick
approved these changes
Aug 2, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
backport-pending/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kvstoremesh is enabled, local agents connect to the local clustermesh-apiserver instance, rather than the remote one. Yet, when the TLS key/certificate pair of a remote cluster is manually specified, the helm chart currently configures it both to connect to the remote clustermesh-apiserver instance (which is correct) and to the local one (which prevents the connection from being established correctly as it is signed with a different CA).
Let's fix this making sure that we always use the local TLS key/certificate pair when connecting to the local
clustermesh-apiserver instance.