Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: nat: enable CT-driven trace aggregation #27178

Merged
merged 1 commit into from Aug 1, 2023

Conversation

julianwiedmann
Copy link
Member

When the NAT code creates a CT entry for a SNATed connection (for instance for EgressGW traffic), pass back the resulting trace information to tail_handle_snat_fwd_ipv*().

Note that this also wires up the path from tail_nodeport_nat_egress_ipv*(), but those connections never require CT on the NAT level.

@julianwiedmann julianwiedmann added kind/enhancement This would improve or streamline existing functionality. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. feature/egress-gateway Impacts the egress IP gateway feature. labels Aug 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 1, 2023
@julianwiedmann julianwiedmann added the release-note/misc This PR makes changes that have no direct user impact. label Aug 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 1, 2023
@julianwiedmann
Copy link
Member Author

/test

When the NAT code creates a CT entry for a SNATed connection (for instance
for EgressGW traffic), pass back the resulting trace information to
tail_handle_snat_fwd_ipv*().

Note that this also wires up the path from tail_nodeport_nat_egress_ipv*(),
but those connections never require CT on the NAT level.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added the feature/snat Relates to SNAT or Masquerading of traffic label Aug 1, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review August 1, 2023 09:32
@julianwiedmann julianwiedmann requested a review from a team as a code owner August 1, 2023 09:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 1, 2023
@dylandreimerink dylandreimerink merged commit 3796d0d into cilium:main Aug 1, 2023
59 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-snat-trace branch August 1, 2023 13:59
@julianwiedmann julianwiedmann added the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Aug 16, 2023
@julianwiedmann julianwiedmann added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/egress-gateway Impacts the egress IP gateway feature. feature/snat Relates to SNAT or Masquerading of traffic kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants