New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: nat: enable CT-driven trace aggregation #27178
Merged
dylandreimerink
merged 1 commit into
cilium:main
from
julianwiedmann:1.15-bpf-snat-trace
Aug 1, 2023
Merged
bpf: nat: enable CT-driven trace aggregation #27178
dylandreimerink
merged 1 commit into
cilium:main
from
julianwiedmann:1.15-bpf-snat-trace
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
kind/enhancement
This would improve or streamline existing functionality.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
area/monitor
Impacts monitoring, access logging, flow logging, visibility of datapath traffic.
feature/egress-gateway
Impacts the egress IP gateway feature.
labels
Aug 1, 2023
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Aug 1, 2023
julianwiedmann
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Aug 1, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Aug 1, 2023
/test |
When the NAT code creates a CT entry for a SNATed connection (for instance for EgressGW traffic), pass back the resulting trace information to tail_handle_snat_fwd_ipv*(). Note that this also wires up the path from tail_nodeport_nat_egress_ipv*(), but those connections never require CT on the NAT level. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-bpf-snat-trace
branch
from
August 1, 2023 08:48
67f994d
to
a0d8cf9
Compare
/test |
gentoo-root
approved these changes
Aug 1, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Aug 1, 2023
3 tasks
julianwiedmann
added
the
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
label
Aug 16, 2023
2 tasks
julianwiedmann
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
labels
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/monitor
Impacts monitoring, access logging, flow logging, visibility of datapath traffic.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
feature/egress-gateway
Impacts the egress IP gateway feature.
feature/snat
Relates to SNAT or Masquerading of traffic
kind/enhancement
This would improve or streamline existing functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NAT code creates a CT entry for a SNATed connection (for instance for EgressGW traffic), pass back the resulting trace information to tail_handle_snat_fwd_ipv*().
Note that this also wires up the path from tail_nodeport_nat_egress_ipv*(), but those connections never require CT on the NAT level.