Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add IPsec key rotation test #27203

Merged
merged 2 commits into from Aug 28, 2023
Merged

CI: Add IPsec key rotation test #27203

merged 2 commits into from Aug 28, 2023

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Aug 2, 2023

This PR adds IPsec key rotation test in conformance-ipsec-e2e.yaml (ci-ipsec-e2e). A new github action conn-disrupt-test is also used to reduce duplication for this test as well as IPsec upgrade test.

Fixes: #26350

Signed-off-by: Zhichuan Liang gray.liang@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 2, 2023
@jschwinger233 jschwinger233 force-pushed the pr/gray/ci-ipsec-key-ro branch 28 times, most recently from 6827ad9 to f09aaa6 Compare August 3, 2023 14:53
@pchaigno
Copy link
Member

pchaigno commented Aug 28, 2023

Restarting because many workflow files got renamed 🙄
/test

@pchaigno
Copy link
Member

@jschwinger233 My retrigger didn't work. I think you'll have to rebase first 😞

This commit adds a step in conformance-ipsec-e2e to perform IPsec key
rotation and conn-disrupt-test.

The commands to perform IPsec key rotation are copied from
https://docs.cilium.io/en/latest/security/network/encryption-ipsec/#key-rotation with a few improvements:
* To pass commands with "$" character to conn-disrupt-test action, "$"
  must be escaped as "\$".
* To have a new IPsec key in a bare VM, a string of hex is hard coded
  without using xxd.

Fixes: #26350

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@jschwinger233
Copy link
Member Author

/test

@pchaigno pchaigno merged commit a4d543d into main Aug 28, 2023
199 checks passed
@pchaigno pchaigno deleted the pr/gray/ci-ipsec-key-ro branch August 28, 2023 11:59
@jschwinger233 jschwinger233 added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 15, 2023
@julianwiedmann julianwiedmann added backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 15, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 4, 2023
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing IPsec key rotation
6 participants