spire: add scheduling configurations to helm-chart #27229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
squeed
requested changes
Aug 3, 2023
|
Seems reasonable. You'll need to update To @meyskens for a SPIRE sanity-check (but it looks fine to me). |
squeed
reviewed
Aug 3, 2023
tvonhacht-apple
force-pushed
the
feature/helm-chart-spire-scheduling
branch
from
05bef2f
to
241d3d1
Compare
joestringer
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Travis is reporting that there's some other docs files that need to be updated too: https://app.travis-ci.com/github/cilium/cilium/builds/264991216
|
tvonhacht-apple
force-pushed
the
feature/helm-chart-spire-scheduling
branch
from
241d3d1
to
fcd4ac9
Compare
meyskens
approved these changes
Aug 4, 2023
|
/test |
|
https://github.com/cilium/cilium/actions/runs/5764251059/job/15627825640 Seems the spire agent is not starting due to these annotations? The sysdumps should give you all info you need |
tvonhacht-apple
force-pushed
the
feature/helm-chart-spire-scheduling
branch
2 times, most recently
from
4cb3bb1
to
85dca77
Compare
|
/test |
tvonhacht-apple
force-pushed
the
feature/helm-chart-spire-scheduling
branch
from
85dca77
to
ba7f212
Compare
|
/test |
Previously, it was not possible to run the spire-agent on nodes with taints like the cilium-agent does by default. This feature matches similar behaviour. Added as well options to define affinity, nodeSelector and tolerations for spire-server. Fixes: cilium#27228 Signed-off-by: Thorben von Hacht <tvonhacht@apple.com>
tvonhacht-apple
force-pushed
the
feature/helm-chart-spire-scheduling
branch
from
ba7f212
to
08bd258
Compare
|
/test |
squeed
approved these changes
Aug 11, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
8 tasks
sayboras
added
the
needs-backport/1.14
2 tasks
tklauser
added
backport-pending/1.14
tklauser
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #27228line if the commit addresses a particularGitHub issue.
Previously, it was not possible to run the spire-agent on nodes with taints like the cilium-agent does by default. This feature matches similar behaviour.
Added as well options to define affinity, nodeSelector and tolerations for spire-server.
Fixes: #27228