Fix agent panic in case of malformed objects retrieved from the kvstore, and improve validation #27237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
kind/bug
|
/test |
pippolo84
approved these changes
Aug 3, 2023
Comment on lines
+631
to
+637
| if n.ClusterID != option.Config.ClusterID { | ||
| if err := cmtypes.ValidateClusterID(n.ClusterID); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Possible style improvement:
Suggested change
| if n.ClusterID != option.Config.ClusterID { | |
| if err := cmtypes.ValidateClusterID(n.ClusterID); err != nil { | |
| return err | |
| } | |
| } | |
| return nil | |
| if n.ClusterID == option.Config.ClusterID { | |
| return nil | |
| } | |
| return cmtypes.ValidateClusterID(n.ClusterID) |
There was a problem hiding this comment.
Generally speaking, I agree that your proposal is cleaner. I'd personally prefer to preserve the current approach, though, as it simplifies the addition of further checks, and it is consistent with the services validation.
squeed
approved these changes
Aug 3, 2023
Currently, the backends of global services received from remote clusters are parsed using `MustParseAddrCluster`. Hence, a global service with an invalid backend IP will cause the crash of all agents. Let's avoid this using `ParseAddrCluster` and handling the error. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Add a validation function to prevent unmarshalling invalid global service objects retrieved from the kvstore, which could then possibly trigger unexpected behavior. Currently, we check that the cluster ID is in the valid range, and that IP addresses are valid. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Add a validation function to prevent unmarshalling invalid node objects retrieved from the kvstore, which could then possibly trigger unexpected behavior. Currently, we only check that the cluster ID is in the valid range. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/clustermesh-validation
branch
from
e300f61
to
f5816dc
Compare
|
The last push reverted a minor modification for better consistency with the previous implementation, with no functional differences. |
|
/test |
ysksuzuki
approved these changes
Aug 7, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
joamaki
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.1
joamaki
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extra validation to prevent processing invalid node and service objects retrieved from the kvstore, which could trigger unexpected behavior.