Re-auth if signal got send again after added to cache #27241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
meyskens
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
meyskens
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
joestringer
approved these changes
Aug 4, 2023
joestringer
added
the
needs-backport/1.14
sayboras
approved these changes
Aug 9, 2023
meyskens
force-pushed
the
meyskens/robust-auth-map
branch
4 times, most recently
from
b7ff839
to
332fa25
Compare
|
/test |
joestringer
reviewed
Aug 23, 2023
This change will re-trigger the auth mechanism if a signal got send but the entry was already in cache. It adds a 1 second backoff time to allow for the backend map to finish updating, which is why it was added in the first place. Signed-off-by: Maartje Eyskens <maartje@eyskens.me> Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/robust-auth-map
branch
from
332fa25
to
97568d4
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
pippolo84
added
the
backport-pending/1.14
pippolo84
removed
the
needs-backport/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.2
michi-covalent
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will re-trigger the auth mechanism if a signal got send but the entry was already in cache.
It adds a 1 second backoff time to allow for the backend map to finish updating, which is why it was added in the first place.
Why does this happen? If somebody removes the entry in the bpf map that is not notified to the cell cache (meaning an external actor) we currently refuse to do the auth handshake again till the entry in the cache is gone.
It does add a small backoff time to not cause un-needed handshakes when data arrives and signals auth_needed between the mutex being released and the datapath getting the update. The current time it will allow for that is 1 second which seems to be okay. It is currently not configurable as it is quite an internal complexity. However I am open to reasons we should export it.
Fixes: #27183