improv: check for k8s backing before running sync #27269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
kwakubiney
force-pushed
the
improv/ignore-synctok8scontroller-for-some-endpoints
branch
from
ce12572
to
3c4803e
Compare
dylandreimerink
added
kind/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
dylandreimerink
added
kind/cleanup
Signed-off-by: kwakubiney <kebiney@hotmail.com>
kwakubiney
force-pushed
the
improv/ignore-synctok8scontroller-for-some-endpoints
branch
from
3c4803e
to
90f5fc8
Compare
|
/test |
squeed
reviewed
Aug 7, 2023
| @@ -95,14 +103,6 @@ func (epSync *EndpointSynchronizer) RunK8sCiliumEndpointSync(e *endpoint.Endpoin | |||
| return fmt.Errorf("Kubernetes apiserver is not available") | |||
There was a problem hiding this comment.
Can this condition (k8s connectivity) change as well, or can we also hoist it out of the controller?
There was a problem hiding this comment.
I'd look at it but looks like PR has been merged?
squeed
approved these changes
Aug 7, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
kwakubiney
deleted the
improv/ignore-synctok8scontroller-for-some-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the synchronisation controller does not run at all when the endpoint has no
CEPname, which implies that it also has no pod backing.Fixes: #27128