gateway-api: Filter routes based on Section Name and port #27309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make sure that we are having a correct attached routes in gateway
status. The translation logic is already implemented such filters, but it
was overlooked in Gateway status.
For the below spec, the attached routes for both listeners was showing as 1,
the expected behavior should be 0 for http-non-attached listener, and 1 for
http listener. Similar scenario should be applied for port number.
```yaml
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
name: sample
spec:
gatewayClassName: cilium
listeners:
- name: http-unattached
port: 8080
protocol: HTTP
allowedRoutes:
kinds:
- kind: HTTPRoute
namespaces:
from: All
- name: http
port: 80
protocol: HTTP
allowedRoutes:
kinds:
- kind: HTTPRoute
namespaces:
from: All
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
name: http-route-4
spec:
parentRefs:
- kind: Gateway
name: sample
sectionName: http
rules:
- backendRefs:
- name: infra-backend-v1
port: 8080
```
Signed-off-by: Tam Mach <tam.mach@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
release-note/bug
|
/test |
aanm
requested changes
Aug 7, 2023
Resource name in k8s cannot be longer than 63 character, so this commit is to make sure that we don't have longer name due to cilium gateway prefix (e.g. cilium-gateway-) for related resources. ``` 2023-08-07T03:23:44.780547229Z level=error msg="Unable to create Service" controller=gateway error="Service \"cilium-gateway-gateway-with-two-listeners-and-one-attached-route\" is invalid: metadata.name: Invalid value: \"cilium-gateway-gateway-with-two-listeners-and-one-attached-route\": must be no more than 63 characters" resource=gateway-conformance-infra/gateway-with-two-listeners-and-one-attached-route subsys=gateway-controller ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gateway-api-listener-matching
branch
from
c0520bd
to
e4c4156
Compare
|
/test |
aanm
approved these changes
Aug 15, 2023
mhofstetter
approved these changes
Aug 15, 2023
|
Reviews from required teams are in, merging this in. |
tklauser
added
backport-pending/1.14
joestringer
added
backport-done/1.14
joestringer
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.2
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please refer to individual commit for more details.