Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutual-auth: Add note for PVC requirement #27311

Merged
merged 1 commit into from Aug 7, 2023
Merged

mutual-auth: Add note for PVC requirement #27311

merged 1 commit into from Aug 7, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Aug 7, 2023

Relates: #26930 (comment)

@sayboras
mutual-auth: Add note for PVC requirement
78c42b2 
Relates: cilium#26930 (comment)
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras requested review from a team as code owners August 7, 2023 06:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 7, 2023
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh labels Aug 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 7, 2023
@sayboras sayboras added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.1 Aug 7, 2023
youngnick
youngnick approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sayboras!

@youngnick youngnick removed the request for review from meyskens August 7, 2023 06:08
@sayboras
Copy link
Member Author

sayboras commented Aug 7, 2023

/test

@sayboras sayboras merged commit 1c81577 into cilium:main Aug 7, 2023
56 checks passed
@sayboras sayboras deleted the tam/pvc-requirement branch August 7, 2023 09:48
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 7, 2023
@joamaki joamaki mentioned this pull request Aug 8, 2023
Merged
9 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.1 Aug 8, 2023
@joamaki joamaki added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.1 Aug 9, 2023
@nebril nebril mentioned this pull request Aug 10, 2023
Merged
@youngnick youngnick mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdanis lambdanis lambdanis approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.1
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayboras @lambdanis @youngnick @joamaki