ipcache: Skip conflict logging for tunnelpeer if native routing #27331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
kind/enhancement
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
See cilium#26817 and specifically cilium#26817 (comment) for more details. In summary, it is safe to skip logging the tunnelpeer conflict if Cilium is configured with native routing, because the tunnel is not used at all anyway. The log msg was triggered in the case that the router IP was configured to be the same across all nodes, a la `--local-router-ip`, in native routing mode. Fixes: cilium#26817 Suggested-by: Tamilmani Manoharan <tamanoha@microsoft.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/skip-log-tunnel-conflict
branch
from
d70149c
to
b2a03d5
Compare
|
/test |
1 task
tamilmani1989
approved these changes
Aug 10, 2023
aditighag
approved these changes
Aug 10, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Hi @christarazi, can this change be backported to cilium 1.14 so we can skip these messages? Using cilium 1.14.4 with note: I was able to cherry-pick this pr onto the latest 1.14 release without conflict |
christarazi
added
the
needs-backport/1.14
giorio94
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26817 and specifically
#26817 (comment)
for more details.
In summary, it is safe to skip logging the tunnelpeer conflict if Cilium
is configured with native routing, because the tunnel is not used at all
anyway.
The log msg was triggered in the case that the router IP was configured
to be the same across all nodes, a la
--local-router-ip, in nativerouting mode.
Fixes: #26817
Suggested-by: Tamilmani Manoharan tamanoha@microsoft.com
Signed-off-by: Chris Tarazi chris@isovalent.com