endpointmanager: unexport and inline functions only used in the package #27426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods no longer have any external users since commits a09ab3a ("endpoint: Move endpoint.Expose to EndpointManager") and 6046592 ("endpoint: Move endpoint.Unexpose to EndpointManager"). Inline them, because they are each only used in a single place in the package. Signed-off-by: Tobias Klauser <tobias@cilium.io>
This method is no longer used outside of the package since the refactoring of endpoint management (namely the removal of the of the endpoint.endpointManager interface) in PR #14745. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
kind/cleanup
|
/test |
tklauser
changed the title
aditighag
approved these changes
Aug 10, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexport and/or inline some functions that are only used in
pkg/endpointmanager.See commit messages for details.