egressgw: test for conflicting IP rules in ENI mode #27428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
release-note/ci
|
/test |
jibi
approved these changes
Aug 31, 2023
This has the advantage of translating a NULL destination in the rules to 0.0.0.0. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When the DestCIDR of a policy changes, we first add the new IP rules before deleting the old ones. But if the new DestCIDR is 0.0.0.0, attempting to install the matching IP rules results in an -EEXIST error. To deal with this, addMissingIpRulesAndRoutes() returns a `shouldRetry` value. If it is set, we retry the installation after removeUnusedIpRulesAndRoutes() has deleted the unused rules. Add a test for this scenario. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-egressgw-rules-conflict-test
branch
from
23c5ff1
to
e94fd99
Compare
|
/test |
|
(no-change rebase to get CI healthy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DestCIDR of a policy changes, we first add the new IP rules before
deleting the old ones. But if the new DestCIDR is 0.0.0.0, attempting to
install the matching IP rules results in an -EEXIST error.
To deal with this, addMissingIpRulesAndRoutes() returns a
shouldRetryvalue. If it is set, we retry the installation after
removeUnusedIpRulesAndRoutes() has deleted the unused rules.
Add a test for this scenario.