gateway-api: Support all the extended features #27472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/ci-gateway-api |
|
/ci-ingress |
sayboras
force-pushed
the
tam/gateway-api-extended-feature
branch
from
53ab756
to
2dbda6e
Compare
|
/test-ingress |
|
/test-gateway |
|
/test-gateway-api |
|
/ci-gateway-api |
|
/ci-ingress |
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
force-pushed
the
tam/gateway-api-extended-feature
branch
3 times, most recently
from
6e0e633
to
4c7198c
Compare
|
/test |
sayboras
force-pushed
the
tam/gateway-api-extended-feature
branch
from
4c7198c
to
93aff6f
Compare
|
/test |
1 similar comment
|
/test |
nbusseneau
approved these changes
Aug 17, 2023
mhofstetter
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
LGTM - thanks a lot @sayboras ! 🚀 Only some non blocking input from my side (see inline comments).
btw: I didn't check all functionality in detail and hope this is covered by Gateway-API conformance tests too.
maintainer-s-little-helper
bot
added
ready-to-merge
This is to add the support for extended feature HTTPRouteHostRewrite. Signed-off-by: Tam Mach <tam.mach@cilium.io>
For prefix rewrite to work, we need to change the prefix match based on regex to PathSeparatedPrefix route match, so that the prefix match is recognized correctly. Signed-off-by: Tam Mach <tam.mach@cilium.io>
This commit is to enable HTTP redirect for port, schema and path. Small fix for TLS filter match on server name is done to avoid the below issue. As part of recent changes in upstream, if scheme and port are not specified, gateway listener port must be used. ```console 2023-08-16T11:28:20.797264246Z level=warning msg="NACK received for versions after 52 and up to 53; waiting for a version update before sending again" subsys=xds xdsAckedVersion=52 xdsClientNode="host~127.0.0.1~no-id~localdomain" xdsDetail="Error adding/updating listener(s) gateway-conformance-infra/cilium-gateway-same-namespace-with-https-listener/listener: error adding listener '127.0.0.1:10605': partial wildcards are not supported in \"server_names\"\n" xdsNonce=53 xdsStreamID=2 xdsTypeURL=type.googleapis.com/envoy.config.listener.v3.Listener ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
All validation logic in HTTPRoute is applied the same as with the normal backend, as backend for mirror requests is consolidated and merged with other backends in the same HTTPRoute. Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gateway-api-extended-feature
branch
from
ad757d9
to
76e9da1
Compare
sayboras
removed
the
ready-to-merge
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
needs-backport/1.14
2 tasks
sayboras
added
backport/author
sayboras
added
backport-pending/1.14
sayboras
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to support the below extended feature in Gateway API, which is currently missing in profile conformance report https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/reports/v0.7.1/cilium-cilium.yaml.