Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: complexity-tests: set -DHAVE_LARGE_INSN_LIMIT=1 for new kernels #27490

Merged
merged 1 commit into from Aug 14, 2023
Merged

bpf: complexity-tests: set -DHAVE_LARGE_INSN_LIMIT=1 for new kernels #27490

merged 1 commit into from Aug 14, 2023

Conversation

julianwiedmann
Copy link
Member

Reflect that 5.2+ kernels have
torvalds/linux@c04c0d2

This allows us to run the complexity tests with programs that more closely resemble what Cilium actually uses. For instance lib/conntrack.h and lib/snat.h will now pull in additional code.

@julianwiedmann
bpf: complexity-tests: set -DHAVE_LARGE_INSN_LIMIT=1 for new kernels
5fa879b 
Reflect that 5.2+ kernels have
torvalds/linux@c04c0d2

This allows us to run the complexity tests with programs that more closely
resemble what Cilium actually uses. For instance lib/conntrack.h and
lib/snat.h will now pull in additional code.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. kind/complexity-issue Relates to BPF complexity or program size issues labels Aug 14, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner August 14, 2023 12:15
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
Copy link
Member Author

As example

before:

tail_nodeport_nat_egress_ipv4: processed 4908 insns (limit 1000000) max_states_per_insn 7 total_states 378 peak_states 217 mark_read 36 (1208 unverified insns)

after:

tail_nodeport_nat_egress_ipv4: processed 25060 insns (limit 1000000) max_states_per_insn 10 total_states 2083 peak_states 503 mark_read 132 (2733 unverified insns)

@julianwiedmann julianwiedmann merged commit a83c043 into cilium:main Aug 14, 2023
60 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-complexity-large-insn-limit branch August 14, 2023 14:11
@julianwiedmann
Copy link
Member Author

@borkmann what's your gut feeling, should we backport (to v1.13+ maybe?) to catch complexity regressions in CI?

@jibi jibi added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 25, 2023
@jibi jibi mentioned this pull request Aug 25, 2023
Merged
3 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@YutaroHayakawa YutaroHayakawa Awaiting requested review from YutaroHayakawa YutaroHayakawa is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/complexity-issue Relates to BPF complexity or program size issues release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @borkmann @jibi